Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARCRC new ontology terms + formatting + metadata, SALMON new run size term + formatting + metadata #134

Merged
merged 13 commits into from
Sep 5, 2024

Conversation

justinkadi
Copy link
Contributor

ARCRC turtle file

  • Added new terms for ARCRC 2023
  • Reformat/collapse namespaces and prefixes
  • Add metadata, update version

SALMON turtle file

  • Added run size term for SALMON
  • Reformat/collapse namespaces and prefixes
  • Add metadata, update version

@justinkadi justinkadi requested a review from mbjones August 23, 2024 19:05
@justinkadi
Copy link
Contributor Author

@mbjones it looks like there were some checks that failed. Are these things that I should be able to fix?

@mbjones
Copy link
Member

mbjones commented Aug 24, 2024

@justinkadi the validate check is something you can fix -- there's a syntax problem of some sort on the indicated line of the ontology file. Should be pretty easy to track down. We don't want to do a release until the CI/validate check works. The other failing test is the Mosiac check, which hasn't worked in a long time (I traced it down to a change in the MOSAiC service, so its not your ontology changes causing it, and you can ignore it for now (you aren't even working on the MOSAiC ontology).

@justinkadi
Copy link
Contributor Author

@mbjones I was able to fix the CI/validate check. I noticed the CI/website was skipped, but I think it's ready for merging otherwise.

Copy link
Member

@mbjones mbjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me with the syntax change.

@mbjones mbjones merged commit fedc11b into main Sep 5, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants