Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove config telemetry normalization tests #5082

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

bm1549
Copy link
Contributor

@bm1549 bm1549 commented Jan 8, 2025

What does this PR do?

Removes the config telemetry normalization rules

Motivation

These tests are duplicated in system tests as part of test_config_telemetry_completeness. This streamlines the experience of adding a new config option

Additional Notes

@bm1549 bm1549 requested a review from a team as a code owner January 8, 2025 14:52
Copy link

github-actions bot commented Jan 8, 2025

Overall package size

Self size: 8.36 MB
Deduped: 94.71 MB
No deduping: 95.22 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.3.0 | 29.43 MB | 29.43 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.4.1 | 9.76 MB | 10.13 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.6.1 | 2.59 MB | 2.73 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter
Copy link

pr-commenter bot commented Jan 8, 2025

Benchmarks

Benchmark execution time: 2025-01-09 22:31:10

Comparing candidate commit cfe47b4 in PR branch bm1549/remove-config-norm-test with baseline commit 6e5d2e8 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 776 metrics, 22 unstable metrics.

simon-id
simon-id previously approved these changes Jan 9, 2025
@simon-id
Copy link
Member

simon-id commented Jan 9, 2025

the benchmarks are hallucinating

@bm1549 bm1549 force-pushed the bm1549/remove-config-norm-test branch from f2a0405 to cfe47b4 Compare January 9, 2025 22:23
@bm1549 bm1549 requested a review from simon-id January 9, 2025 22:23
@bm1549 bm1549 enabled auto-merge (squash) January 9, 2025 22:59
@bm1549 bm1549 merged commit 858b2a1 into master Jan 9, 2025
329 checks passed
@bm1549 bm1549 deleted the bm1549/remove-config-norm-test branch January 9, 2025 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants