Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix trace log level not adding parameters to output #5069

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

rochdev
Copy link
Member

@rochdev rochdev commented Jan 6, 2025

What does this PR do?

Fix trace log level not adding parameters to output.

Motivation

Errors without a message don't have a : so the string replacement wasn't working.

Additional Notes

The test wasn't changed because this behaviour doesn't happen in tests, presumably because the test framework is patching errors.

Copy link

github-actions bot commented Jan 6, 2025

Overall package size

Self size: 8.41 MB
Deduped: 94.76 MB
No deduping: 95.27 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.3.0 | 29.43 MB | 29.43 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.4.1 | 9.76 MB | 10.13 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.6.1 | 2.59 MB | 2.73 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter
Copy link

pr-commenter bot commented Jan 6, 2025

Benchmarks

Benchmark execution time: 2025-01-07 05:11:37

Comparing candidate commit d7ea4c6 in PR branch fix-log-trace-error with baseline commit 12f2418 in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 778 metrics, 19 unstable metrics.

scenario:plugin-graphql-with-async-hooks-22

  • 🟩 max_rss_usage [-124.291MB; -116.737MB] or [-19.100%; -17.939%]

@rochdev rochdev force-pushed the fix-log-trace-error branch from 3ee630e to d7ea4c6 Compare January 7, 2025 05:00
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.45%. Comparing base (12f2418) to head (d7ea4c6).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5069      +/-   ##
==========================================
- Coverage   95.37%   87.45%   -7.93%     
==========================================
  Files          11      130     +119     
  Lines         476     4624    +4148     
==========================================
+ Hits          454     4044    +3590     
- Misses         22      580     +558     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rochdev rochdev marked this pull request as ready for review January 7, 2025 05:13
@rochdev rochdev requested a review from a team as a code owner January 7, 2025 05:13
@rochdev rochdev merged commit c7648a7 into master Jan 7, 2025
307 checks passed
@rochdev rochdev deleted the fix-log-trace-error branch January 7, 2025 17:04
@rochdev rochdev mentioned this pull request Jan 8, 2025
@rochdev rochdev mentioned this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants