Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNS Lookup event hostname is sometimes not a string #5067

Merged
merged 2 commits into from
Jan 10, 2025
+17 −1
Merged

DNS Lookup event hostname is sometimes not a string #5067

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
893c27c
Ensure we aren't tripped up by non-string event details
szegedi Jan 3, 2025
56d7ccc
Avoid invoking potentially unbounded computation in object toString m…
szegedi Jan 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion packages/dd-trace/src/profiling/profilers/events.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,23 @@ const pprofValueUnit = 'nanoseconds'
const dateOffset = BigInt(Math.round(performance.timeOrigin * MS_TO_NS))

function labelFromStr (stringTable, key, valStr) {
return new Label({ key, str: stringTable.dedup(valStr) })
return new Label({ key, str: stringTable.dedup(safeToString(valStr)) })
}

// We don't want to invoke toString for objects and functions, rather we'll
// provide dummy values. These values are not meant to emulate built-in toString
// behavior.
function safeToString (val) {
switch (typeof val) {
case 'string':
return val
case 'object':
return '[object]'
case 'function':
return '[function]'
default:
return String(val)
}
}

function labelFromStrStr (stringTable, keyStr, valStr) {
Expand Down
Loading