Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Report stack trace in iast #5055

Merged
merged 16 commits into from
Jan 23, 2025
Merged

Report stack trace in iast #5055

merged 16 commits into from
Jan 23, 2025

Conversation

IlyasShabi
Copy link
Contributor

What does this PR do?

Add stack trace report to IAST events

Plugin Checklist

Additional Notes

Copy link

github-actions bot commented Dec 23, 2024

Overall package size

Self size: 8.53 MB
Deduped: 94.88 MB
No deduping: 95.4 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.4.0 | 29.44 MB | 29.44 MB | | @datadog/native-appsec | 8.4.0 | 19.25 MB | 19.26 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.4.1 | 9.76 MB | 10.13 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.6.1 | 2.59 MB | 2.73 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@pr-commenter
Copy link

pr-commenter bot commented Dec 23, 2024

Benchmarks

Benchmark execution time: 2025-01-23 13:42:24

Comparing candidate commit a17f4d9 in PR branch iast-stack-trace with baseline commit dcf3c7e in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 901 metrics, 26 unstable metrics.

scenario:plugin-graphql-with-depth-and-collapse-on-18

  • 🟩 max_rss_usage [-57.420MB; -48.948MB] or [-5.904%; -5.033%]

@IlyasShabi IlyasShabi marked this pull request as ready for review December 24, 2024 15:17
@IlyasShabi IlyasShabi requested a review from a team as a code owner December 24, 2024 15:17
@IlyasShabi IlyasShabi marked this pull request as draft January 10, 2025 13:38
@IlyasShabi IlyasShabi force-pushed the iast-stack-trace branch 2 times, most recently from d37649a to 325ba0d Compare January 13, 2025 09:49
@IlyasShabi IlyasShabi force-pushed the iast-stack-trace branch 3 times, most recently from 365d55b to 99410fb Compare January 14, 2025 21:37
@IlyasShabi IlyasShabi marked this pull request as ready for review January 15, 2025 09:48
@IlyasShabi IlyasShabi requested a review from a team as a code owner January 17, 2025 10:53
@IlyasShabi IlyasShabi marked this pull request as draft January 17, 2025 10:56
@IlyasShabi IlyasShabi marked this pull request as ready for review January 20, 2025 15:12
@iunanua
Copy link
Contributor

iunanua commented Jan 23, 2025

LGTM 🎉

@IlyasShabi IlyasShabi merged commit 30efc06 into master Jan 23, 2025
331 checks passed
@IlyasShabi IlyasShabi deleted the iast-stack-trace branch January 23, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants