Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DI] Improve sampling tests #4999

Merged
merged 3 commits into from
Dec 13, 2024
Merged

[DI] Improve sampling tests #4999

merged 3 commits into from
Dec 13, 2024

Conversation

watson
Copy link
Collaborator

@watson watson commented Dec 11, 2024

To test that multiple probes doesn't interfere with each others sample rate, this PR also adds support for multiple breakpoints in a single file.

Copy link
Collaborator Author

watson commented Dec 11, 2024

Copy link

github-actions bot commented Dec 11, 2024

Overall package size

Self size: 8.25 MB
Deduped: 94.54 MB
No deduping: 95.06 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.2.2 | 29.27 MB | 29.27 MB | | @datadog/native-appsec | 8.3.0 | 19.37 MB | 19.38 MB | | @datadog/native-iast-taint-tracking | 3.2.0 | 13.9 MB | 13.91 MB | | @datadog/pprof | 5.4.1 | 9.76 MB | 10.13 MB | | protobufjs | 7.2.5 | 2.77 MB | 5.16 MB | | @datadog/native-iast-rewriter | 2.6.0 | 2.58 MB | 2.72 MB | | @opentelemetry/core | 1.14.0 | 872.87 kB | 1.47 MB | | @datadog/native-metrics | 3.0.1 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.11.2 | 112.74 kB | 826.22 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.0 | 109.9 kB | 109.9 kB | | semver | 7.6.3 | 95.82 kB | 95.82 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.1 | 51.46 kB | 51.46 kB | | shell-quote | 1.8.1 | 44.96 kB | 44.96 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.3.1 | 25.21 kB | 25.21 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | dc-polyfill | 0.1.4 | 23.1 kB | 23.1 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.46%. Comparing base (4304684) to head (afd7db4).

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4999       +/-   ##
===========================================
+ Coverage        0   74.46%   +74.46%     
===========================================
  Files           0      191      +191     
  Lines           0     7177     +7177     
===========================================
+ Hits            0     5344     +5344     
- Misses          0     1833     +1833     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Dec 11, 2024

Benchmarks

Benchmark execution time: 2024-12-13 19:16:13

Comparing candidate commit cbe9a00 in PR branch watson/DEBUG-2614/improve-tests with baseline commit 83c6928 in branch master.

Found 3 performance improvements and 0 performance regressions! Performance is the same for 259 metrics, 4 unstable metrics.

scenario:plugin-graphql-with-depth-and-collapse-on-18

  • 🟩 max_rss_usage [-83.002MB; -72.034MB] or [-8.827%; -7.661%]

scenario:plugin-graphql-with-depth-off-18

  • 🟩 max_rss_usage [-92.696MB; -72.556MB] or [-9.876%; -7.730%]

scenario:plugin-graphql-with-depth-on-max-18

  • 🟩 max_rss_usage [-82.887MB; -72.973MB] or [-8.782%; -7.732%]

@watson watson force-pushed the watson/DEBUG-2614/sampling branch from afd86e3 to da0fc35 Compare December 11, 2024 17:37
@watson watson force-pushed the watson/DEBUG-2614/improve-tests branch from 3dcf6db to bc0530a Compare December 11, 2024 17:37
@watson watson force-pushed the watson/DEBUG-2614/sampling branch from da0fc35 to acbba64 Compare December 12, 2024 07:04
@watson watson force-pushed the watson/DEBUG-2614/improve-tests branch from bc0530a to 2d7b3c3 Compare December 12, 2024 07:04
@watson watson force-pushed the watson/DEBUG-2614/sampling branch from acbba64 to 1fa77b3 Compare December 12, 2024 12:54
@watson watson force-pushed the watson/DEBUG-2614/improve-tests branch from 2d7b3c3 to 26e9747 Compare December 12, 2024 12:54
Base automatically changed from watson/DEBUG-2614/sampling to master December 12, 2024 18:24
To test that multiple probes doesn't interfere with each others sample
rate, this commit also adds support for multiple breakpoints in a single
file.
@watson watson force-pushed the watson/DEBUG-2614/improve-tests branch from 26e9747 to b1b5e20 Compare December 12, 2024 18:24
@watson watson marked this pull request as ready for review December 12, 2024 18:25
@watson watson requested review from a team as code owners December 12, 2024 18:25
@watson watson enabled auto-merge (squash) December 13, 2024 12:32
@watson watson merged commit 7b5ccb2 into master Dec 13, 2024
289 of 290 checks passed
@watson watson deleted the watson/DEBUG-2614/improve-tests branch December 13, 2024 19:18
@rochdev rochdev mentioned this pull request Dec 17, 2024
rochdev pushed a commit that referenced this pull request Dec 17, 2024
To test that multiple probes doesn't interfere with each others sample
rate, this commit also adds support for multiple breakpoints in a single
file.
@rochdev rochdev mentioned this pull request Dec 17, 2024
rochdev pushed a commit that referenced this pull request Dec 17, 2024
To test that multiple probes doesn't interfere with each others sample
rate, this commit also adds support for multiple breakpoints in a single
file.
rochdev pushed a commit that referenced this pull request Dec 18, 2024
To test that multiple probes doesn't interfere with each others sample
rate, this commit also adds support for multiple breakpoints in a single
file.
rochdev pushed a commit that referenced this pull request Dec 18, 2024
To test that multiple probes doesn't interfere with each others sample
rate, this commit also adds support for multiple breakpoints in a single
file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants