[DI] Ensure probes without a 'sampling' property is parsed correctly

DataDog · Jan 9, 2025 · 4fdee9c · 4fdee9c
1 parent b36ce05
commit 4fdee9c
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/dd-trace/src/debugger/devtools_client/breakpoints.js b/packages/dd-trace/src/debugger/devtools_client/breakpoints.js
@@ -23,10 +23,10 @@ async function addBreakpoint (probe) {
   delete probe.where
 
   // Optimize for fast calculations when probe is hit
-  const snapshotsPerSecond = probe.sampling.snapshotsPerSecond ?? (probe.captureSnapshot
+  const snapshotsPerSecond = probe.sampling?.snapshotsPerSecond ?? (probe.captureSnapshot
     ? MAX_SNAPSHOTS_PER_SECOND_PER_PROBE
     : MAX_NON_SNAPSHOTS_PER_SECOND_PER_PROBE)
-  probe.sampling.nsBetweenSampling = BigInt(1 / snapshotsPerSecond * 1e9)
+  probe.nsBetweenSampling = BigInt(1 / snapshotsPerSecond * 1e9)
   probe.lastCaptureNs = 0n
 
   // TODO: Inbetween `await session.post('Debugger.enable')` and here, the scripts are parsed and cached.

diff --git a/packages/dd-trace/src/debugger/devtools_client/index.js b/packages/dd-trace/src/debugger/devtools_client/index.js
@@ -42,7 +42,7 @@ session.on('Debugger.paused', async ({ params }) => {
     const id = params.hitBreakpoints[i]
     const probe = breakpoints.get(id)
 
-    if (start - probe.lastCaptureNs < probe.sampling.nsBetweenSampling) {
+    if (start - probe.lastCaptureNs < probe.nsBetweenSampling) {
       continue
     }