service discovery: Add missing cgroup mount #1610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a missing cgroup mount to system-probe which is required to get container information.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1610 +/- ##
==========================================
- Coverage 48.94% 48.77% -0.18%
==========================================
Files 227 235 +8
Lines 20636 21195 +559
==========================================
+ Hits 10101 10337 +236
- Misses 10010 10318 +308
- Partials 525 540 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 11 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
3 tasks
tbavelier
approved these changes
Jan 10, 2025
|
/merge |
Devflow running:
|
dd-devflow
bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
dd-devflow
bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
tbavelier
pushed a commit
that referenced
this pull request
Jan 10, 2025
* service discovery: Add missing cgroup mount Add a missing cgroup mount to system-probe which is required to get container information. * Update test
2 tasks
tbavelier
added a commit
that referenced
this pull request
Jan 10, 2025
* service discovery: Add missing cgroup mount Add a missing cgroup mount to system-probe which is required to get container information. * Update test Co-authored-by: Vincent Whitchurch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a missing cgroup mount to system-probe which is required to get container information for service discovery.
This was not required for earlier agent releases but will be from version 7.61 of the agent.
Motivation
Bug found during manual testing of latest agent release.
Additional Notes
The same mount is already added for other features like USM/NPM.
Minimum Agent Versions
Describe your test plan
Follow the instructions on #1449 except use at least version
7.61.0-rc.10of the agent.Run the following command in the system-probe container to check that the
container_idis filled:Checklist
bug,enhancement,refactoring,documentation,tooling, and/ordependenciesqa/skip-qalabel