Some thread-safety modifications in MacOSThemeDetector

Dansoftowner · Apr 16, 2021 · dec4722 · dec4722
1 parent bb40a52
commit dec4722
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/src/main/java/com/jthemedetecor/MacOSThemeDetector.java b/src/main/java/com/jthemedetecor/MacOSThemeDetector.java
@@ -39,12 +39,11 @@ class MacOSThemeDetector extends OsThemeDetector {
 
     private final Set<Consumer<Boolean>> listeners = Collections.synchronizedSet(new HashSet<>());
     private final Pattern themeNamePattern = Pattern.compile(".*dark.*", Pattern.CASE_INSENSITIVE);
-    private final Object iterateLock = new Object();
 
     private final Callback themeChangedCallback = new Callback() {
         @SuppressWarnings("unused")
         public void callback() {
-            synchronized (iterateLock) {
+            synchronized (listeners) {
                 notifyListeners(isDark());
             }
         }
@@ -100,14 +99,14 @@ private boolean isDarkTheme(String themeName) {
 
     @Override
     public void registerListener(@NotNull Consumer<Boolean> darkThemeListener) {
-        synchronized (iterateLock) {
+        synchronized (listeners) {
             listeners.add(darkThemeListener);
         }
     }
 
     @Override
     public void removeListener(@Nullable Consumer<Boolean> darkThemeListener) {
-        synchronized (iterateLock) {
+        synchronized (listeners) {
             listeners.remove(darkThemeListener);
         }
     }