[Refactor] #197 - 미션 리스트 디테일 UI 로직 변경 #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyesuuou
reviewed
Nov 26, 2023
| guard let data = response.data else { return } | ||
| self.nottodoInfoList[1] = data.title | ||
| self.nottodoInfoList[2] = data.situation | ||
| self.nottodoInfoList[3] = data.actions.first!.name |
There was a problem hiding this comment.
호옥시나 데이터가 빈걸로 넘어오면 크래시가 발생할 수도 있을 것 같아서 안전하게 언래핑 해주면 좋을 것 같아욥~
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🫧 작업한 내용
🔫 PR Point
리팩토링하면서 cancel버튼과 edit 버튼은 따로 headerTopview로 구현하여 스크롤 영역을 수정했습니다.
또한, 레이아웃의 속성을
UICollectionLayoutListConfiguration(appearance: .plain)으로 주었더니 footer는 스크롤이 되지 않아서 속성을UICollectionLayoutListConfiguration(appearance: .grouped)으로 변경했습니다.📸 스크린샷
기존 화면
Simulator.Screen.Recording.-.iPhone.SE.3rd.generation.-.2023-11-19.at.01.10.15.mp4
수정된 화면
Simulator.Screen.Recording.-.iPhone.SE.3rd.generation.-.2023-11-19.at.03.48.32.mp4
📮 관련 이슈