Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make install work with non interactive zsh shells #779

Closed
wants to merge 1 commit into from
Closed

fix: make install work with non interactive zsh shells #779

wants to merge 1 commit into from

Conversation

0ximmeas
Copy link

fix for #778, .zshenv is sourced in all shells, including non-interactive

@0ximmeas 0ximmeas requested a review from alexroan as a code owner November 11, 2024 13:50
@0ximmeas
Copy link
Author

Manually tested in both interactive and non-interactive zsh shell (and it's the same way as foundryup does it)

@alexroan
Copy link
Contributor

Thank you @0ximmeas , resolved in #787 :)

@alexroan alexroan closed this Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexroan alexroan Awaiting requested review from alexroan alexroan is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0ximmeas @alexroan