Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial Set support #196

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Initial Set support #196

wants to merge 2 commits into from

Conversation

fde31
Copy link
Member

@fde31 fde31 commented Jan 3, 2025

closes #182

@fde31 fde31 requested a review from x37v January 3, 2025 13:22
Copy link
Contributor

@x37v x37v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks great, the only thing i think it is missing is the ability to clear the initial set setting.. you can just set it to an empty string via OSC. not sure what the UI should look like for that though

@fde31
Copy link
Member Author

fde31 commented Jan 8, 2025

as per the discussion yday - would that operation be a thing if there were to always be a set as in the initial couldn't be empty?

@x37v
Copy link
Contributor

x37v commented Jan 11, 2025

as per the discussion yday - would that operation be a thing if there were to always be a set as in the initial couldn't be empty

yeah.. there are currently a few behaviors available for startup:

  1. load an explicit set indicated by initial
  2. load whatever set you last had loaded
  3. load nothing

that is all controlled by a config value and this initial setting (or lack there of), i think it makes sense to keep this setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add support for initial set
2 participants