Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Patcher Node placement & Auto Layouting #188

Merged
merged 9 commits into from
Dec 16, 2024
Merged

Patcher Node placement & Auto Layouting #188

merged 9 commits into from
Dec 16, 2024

Conversation

fde31
Copy link
Member

@fde31 fde31 commented Dec 12, 2024

This moves some of the viewport / editor pane interactions into actions & the state. The version of Reactflow we use doesn't fully support a controlled viewport but this gets us there.

Note that with this PR:

  • the built-in controls menu is replaced with a custom one to also feature the layouting button
  • we introduce an auto-layout functionality
  • width & height of all nodes are controlled in the graph (but not resizable just yet)
  • new patcher nodes should be placed in 0,0 of the current viewport

The migration of existing sets might be a bit clumsy due to the state controlled width & height but hopefully the auto-layout makes this smoother and easier to deal with?!

see #168

Also created #187 for node resizing

@fde31 fde31 requested a review from x37v December 12, 2024 17:20
@fde31
Copy link
Member Author

fde31 commented Dec 12, 2024

@x37v would be cool if you could test that on your end, esp. with existing sets.
The auto-layouting seems ok so far, but I wonder if we want to push "system" nodes out of the graph to the left and right?

Note that a npm ci will be necessary here given some new deps.

Copy link
Contributor

@x37v x37v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

much improved!

@fde31 fde31 merged commit 1bb94ac into develop Dec 16, 2024
1 check passed
@fde31 fde31 deleted the fde/viewport branch December 16, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants