-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding GalaxySpace documentation #584
base: main
Are you sure you want to change the base?
Conversation
Added methods and examples for the Assembly Table
Fixed broken formating.
Added Fuel Generator methods.
Added Gas Generator methods.
Added Hydroponic Farm methods.
Added Liquid Collector method.
Added Universal Recycler methods.
Added Rocket Assembly Machine methods.
Forgot to press enter once.
Replaced a ' with ;
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, it mostly looks good, just a few changes required.
You also need to add the pages to the docs.json
file
```zenscript | ||
//mods.galaxyspace.addAssemblyRecipe(IItemStack Output, IItemStack Input...); | ||
|
||
mods.galaxyspace.addAssemblyRecipe(<minecraft:iron_block>, <minecraft:iron:ingot>, <minecraft:iron:ingot>, <minecraft:iron:ingot>,<minecraft:iron:ingot>, <minecraft:iron:ingot>, <minecraft:iron:ingot>, <minecraft:iron:ingot>, <minecraft:iron:ingot>, <minecraft:iron:ingot>); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have the wrong item name for these
mods.galaxyspace.addAssemblyRecipe(<minecraft:iron_block>, <minecraft:iron:ingot>, <minecraft:iron:ingot>, <minecraft:iron:ingot>,<minecraft:iron:ingot>, <minecraft:iron:ingot>, <minecraft:iron:ingot>, <minecraft:iron:ingot>, <minecraft:iron:ingot>, <minecraft:iron:ingot>); | |
mods.galaxyspace.addAssemblyRecipe(<minecraft:iron_block>, <minecraft:iron_ingot>, <minecraft:iron_ingot>, <minecraft:iron_ingot>, <minecraft:iron_ingot>, <minecraft:iron_ingot>, <minecraft:iron_ingot>, <minecraft:iron_ingot>, <minecraft:iron_ingot>, <minecraft:iron_ingot>); |
## Addition | ||
|
||
```zenscript | ||
//mods.galaxyspace.addHydroponicFarmRecipe(IItemStack seed input, IItemStack output, IItemStack secondary product, int secondary changes, int stages, IBlock block, boolean product random, boolean secondary product random); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think there should be spaces for these parameter names
//mods.galaxyspace.addHydroponicFarmRecipe(IItemStack seed input, IItemStack output, IItemStack secondary product, int secondary changes, int stages, IBlock block, boolean product random, boolean secondary product random); | |
//mods.galaxyspace.addHydroponicFarmRecipe(IItemStack seed_input, IItemStack output, IItemStack secondary_product, int secondary_changes, int stages, IBlock block, boolean product_random, boolean secondary_product_random); |
## Addition | ||
|
||
```zenscript | ||
//mods.galaxyspace.addLiquidExtractorRecipe(IBlock, ILiquidStack output); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the name of the IBlock parameter?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure actually, all I know is that it's the block that needs to be below the machine for this "recipe" to work.
```zenscript | ||
//mods.galaxyspace.addRocketAssemblyRecipe(IItemStack output, IItemStack... inputs); | ||
|
||
mods.galaxyspace.addRocketAssemblyRecipe(<minecraft:iron_block>, <minecraft:iron:ingot>, <minecraft:iron:ingot>, <minecraft:iron:ingot>,<minecraft:iron:ingot>, <minecraft:iron:ingot>, <minecraft:iron:ingot>, <minecraft:iron:ingot>, <minecraft:iron:ingot>, <minecraft:iron:ingot>); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mods.galaxyspace.addRocketAssemblyRecipe(<minecraft:iron_block>, <minecraft:iron:ingot>, <minecraft:iron:ingot>, <minecraft:iron:ingot>,<minecraft:iron:ingot>, <minecraft:iron:ingot>, <minecraft:iron:ingot>, <minecraft:iron:ingot>, <minecraft:iron:ingot>, <minecraft:iron:ingot>); | |
mods.galaxyspace.addRocketAssemblyRecipe(<minecraft:iron_block>, <minecraft:iron_ingot>, <minecraft:iron_ingot>, <minecraft:iron_ingot>, <minecraft:iron_ingot>, <minecraft:iron_ingot>, <minecraft:iron_ingot>, <minecraft:iron_ingot>, <minecraft:iron_ingot>, <minecraft:iron_ingot>); |
## Addition | ||
|
||
```zenscript | ||
//mods.galaxyspace.addRecyclerRecipe(IItemStack input, IItemStack output, optional IItemStack output, ILiquidStack output, int chances); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please use different parameter names for each parameter, also optional
parameters can only go at the end, are the last 2 parameters also optional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad, I thought the method supported adding outputs to the secondary slot of the machine, but it did not, I must've forgotten to remove that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay, the parameter names still need to be unique
Fixed broken item IDs in the example.
Reformated method.
Reformated method.
Removed unused optional ItemStack output.
I've extracted all CraftTweaker methods from GalaxySpace and formated them to hopefully fit in the rest of the wiki.