-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(materials): add 404 folder not found page #7626
Conversation
4b02e06
to
7811db9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very neat PR, except for,
- the controller calling other controller action, and
- anti-patterned
getFolderTitle
definition.
The rest are nitpicks and some questions.
With the new /materials/folders
route, technically we can already replace the path for Workbin on the sidebar. This should reduce about 1-2 SQL calls since there's no need to resolve current_course.root_folder
in main_sidebar_items
in Course::MaterialsComponent
. Just need to ensure that activePath
(hence the active highlight on the sidebar) still works even after this change. But this isn't urgent, and the behaviour this PR brings is already good as it is; it can be another good first issue for others.
da670f3
to
8344117
Compare
3bef4f2
to
35e25a4
Compare
client/app/bundles/course/material/folders/pages/ErrorRetrievingFolderPage.tsx
Outdated
Show resolved
Hide resolved
35e25a4
to
66493a6
Compare
- clean up folders_controller methods - add rspec tests for show and index - clean up rspec tests - remove material root folder query in sidebar
point `/courses/<course-id>/materials/folders` to course root folder
66493a6
to
f308fb8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cysjonathan the code now has been made much cleaner, just one more comment to be addressed, to make the redirection to Root Folder much clearer and easier to understand
before this commit, all folder named 'Root' will be overwritten with course.material.sidebar_title
f308fb8
to
8331fdc
Compare
resolved conversations
resolves issue #7437 by showing a 404 screen when visiting non-existent folders instead of an empty materials table
supersedes PR #7612