Only set unset additionalProperties fields to false
#2310
Conversation
|
@snoyberg apologies for the delay. It would be great if you could run your codegen against this patch and see if the schemas look good. If they do, we can merge this. |
|
Thank you @aumetra! I can confirm that with this change, we end up with the correct generated schema files. Much appreciated! |
| @@ -19,5 +19,6 @@ thiserror = "1.0.26" | |||
|
|
|||
| [dev-dependencies] | |||
| anyhow = "1.0.57" | |||
| insta = { version = "1.41.1", features = ["json"] } | |||
There was a problem hiding this comment.
Nice, didn't know this one yet.
There was a problem hiding this comment.
Yeah, it's pretty neat! Even though it adds a few dev dependencies, but since the PR with the new schema format makes pretty extensive use of insta there's no damage in introducing it here already
|
Could you add a changelog entry? |
|
Oh, looks like we should unify the changelogs of the release branches with main and start a new entry after the 2.2 release. |
Closes #2309