Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix logging #93

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix logging #93

wants to merge 2 commits into from

Conversation

tarrow
Copy link
Contributor

@tarrow tarrow commented Sep 23, 2016 •
edited
Loading

This patch fixes logging in quickscrape by both correcting the parameters to commander as well as using winston properly and assigning the filename before changing dir

@coveralls
Copy link

Coverage Status

Coverage remained the same at 56.0% when pulling 4a59a6c on tarrow:fix-logging into 27dce16 on ContentMine:master.

@tarrow tarrow added ready and removed in progress labels Sep 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tarrow @coveralls