Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix url list processing #66

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix url list processing #66

wants to merge 1 commit into from

Conversation

zemanel
Copy link

@zemanel zemanel commented Nov 17, 2015

When specifying a list of urls to process, through the urllist file param, the last url is not processed.

I believe its a race condition, whereas finish() is called on a setTimeout() tick, without the last url having finished processing.

I removed an finish call as it will be called on the ensuing ticks.

@blahah
Copy link
Member

blahah commented Nov 17, 2015

Thanks for this, I will test and merge asap

@robintw
Copy link

robintw commented Apr 2, 2016

I see this hasn't been merged, but has the fix been included some other way? I can't seem to reproduce the problem.

(If it has been fixed, can this PR be closed?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants