Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update thiserror-core dependency #4332

Merged
merged 1 commit into from
Nov 23, 2023
Merged

chore: update thiserror-core dependency #4332

merged 1 commit into from
Nov 23, 2023

Conversation

mina86
Copy link
Contributor

@mina86 mina86 commented Nov 19, 2023

Admittedly, the only motivation here is wanting numbers to go up. ;)

Required for merge:

  • pr-workflow-check / draft-release-check is ✅ success
  • Other rules GitHub shows you, or can be read in configuration

Makes review faster:

  • PR title is my best effort to provide summary of changes and has clear text to be part of release notes
  • I marked PR by misc label if it should not be in release notes
  • Linked Zenhub/Github/Slack/etc reference if one exists
  • I was clear on what type of deployment required to release my changes (node, runtime, contract, indexer, on chain operation, frontend, infrastructure) if any in PR title or description
  • Added reviewer into Reviewers
  • I tagged(@) or used other form of notification of one person who I think can handle best review of this PR
  • I have proved that PR has no general regressions of relevant features and processes required to release into production
  • Any dependency updates made, was done according guides from relevant dependency
  • Clicking all checkboxes
  • Adding detailed description of changes when it feels appropriate (for example when PR is big)

Copy link

Pull reviewers stats

Stats of the last 30 days for composable:

User Total reviews Time to review Total comments
dzmitry-lahoda 11 4h 48m 10
RustNinja 10 4h 26m 14
mina86 6 1d 1h 41m 23
kkast 6 30m 0
0xBrainjar2 4 22h 36m 12
JafarAz 3 15h 5m 1
blasrodri 2 14h 35m 0
vmarkushin 1 2d 14h 2m 3
bengalmozzi 1 23h 12m 0

Copy link

# run Composable node
nix run "github:ComposableFi/composable/refs/pull/4332/merge" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed
# run local Picasso DevNet (for CosmWasm development)
nix run "github:ComposableFi/composable/refs/pull/4332/merge#devnet-picasso" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# CosmWasm on Substrate CLI tool
nix run "github:ComposableFi/composable/refs/pull/4332/merge#ccw" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# run cross chain devnet with Dotsama and Cosmos nodes 
nix run "github:ComposableFi/composable/refs/pull/4332/merge#devnet-xc-fresh" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed 
# or same with docker
nix build "github:ComposableFi/composable/refs/pull/4332/merge#devnet-xc-image" --allow-import-from-derivation --extra-experimental-features "flakes nix-command" --no-sandbox --accept-flake-config --option sandbox relaxed \
&& docker load --input result && docker run -it --entrypoint bash devnet-xc:latest -c /bin/devnet-xc-fresh 

About nix

@RustNinja RustNinja self-requested a review November 22, 2023 20:18
@mina86 mina86 changed the title Update thiserror-core dependency chore: update thiserror-core dependency Nov 23, 2023
@mina86 mina86 enabled auto-merge (squash) November 23, 2023 00:06
Admittedly, the only motivation here is wanting numbers to go up. ;)
@mina86 mina86 merged commit 07cf541 into main Nov 23, 2023
33 checks passed
@mina86 mina86 deleted the mpn/a branch November 23, 2023 00:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants