completed exercises 2 and 3 #61
Conversation
| 10 error missing script: week | ||
| 11 error If you need help, you may report this error at: | ||
| 11 error <https://github.com/npm/npm/issues> | ||
| 12 verbose exit [ 1, true ] |
There was a problem hiding this comment.
Be careful to review your changes before committing them :). Use git status and git diff to check what's changed and what you are adding, and don't use the commands git add . or git commit -am (even if you see instructions somewhere that say to do that 🙂 ).
| </div> | ||
| </div> | ||
| </main> | ||
| </body> | ||
| </html> |
There was a problem hiding this comment.
The only thing you're meant to do for exercise 1 is add a time value to the HTML. Exercises 2 and 3 should be changes in other files (you don't seem to have done those?).
|
|
||
| #first-message { | ||
| background-color: red; | ||
| } |
| font-size: 0.9rem; | ||
| } | ||
| .message_content { | ||
| opacity: 1; |
There was a problem hiding this comment.
Did you check whether this works? Always run the code (or view the web page here) and make sure the changes you make have the intended effect. Look up what opacity does and try to experiment with different values.
| @@ -11,7 +11,9 @@ | |||
| <body> | |||
| <div class="site-wrapper"> | |||
| <main> | |||
| <p>Delete this line and add your form.</p> | |||
| <form action="https://www.google.com/search" method="Git"> | |||
There was a problem hiding this comment.
You're confusing GET with Git here 🙂
| @@ -37,8 +37,12 @@ <h1 class="shopping-basket__title">Your Shopping Basket</h1> | |||
| <div class="checkout"> | |||
| <h2 class="checkout__title">Checkout</h2> | |||
| <form method="GET" id="checkout-form" class="checkout__form"> | |||
| <!-- Add the form fields here --> | |||
|
|
|||
| <label> for="customer-name">customer-name</label> | |||
There was a problem hiding this comment.
The text values for the labels should be normal text the user will see on screen, so something like "Name" rather than "customer-name", and "Email" rather than "customer-email".
| <input id="customer-name" type="text" name="customer-name"> | ||
| <label for="email">customer-email</label> | ||
| <input id="email" type="email" name="customer-email"> | ||
| <label for="tel">customer-phone</label> |
There was a problem hiding this comment.
The for attribute must match the id attribute of the element it corresponds to. The id isn't tel in this case.
| <form> | ||
| <label>Add Your Message</label> | ||
| <textarea> comment </textarea> | ||
| <button>Send Comment</button> |
There was a problem hiding this comment.
Remember the label must always be explicitly matched to another element (even if it seems obvious to you what it is for here, because there is only one input field. We saw two ways to do this, you can use either.
| <fieldset> | ||
| <legend>dietry requirments</legend> | ||
| <label> | ||
| <input type="checkbox" name="yumy food" value="ha" /> |
There was a problem hiding this comment.
Watch out for typos. You have two fields here, one called yumy food and one called yummy food.
There was a problem hiding this comment.
Tanks for your feedback and recommendation.i will finish the rest of exercises.
No description provided.