Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ParticipantInfo & ParticipanstList Tests #252

Closed
wants to merge 2 commits into from
Closed

ParticipantInfo & ParticipanstList Tests #252

wants to merge 2 commits into from

Conversation

thatzacdavis
Copy link
Collaborator

This PR will address #244 using React Testing Library:

ParticipantInfo

  • Render test
  • Test conditional rendering
  • Snapshot test

ParticipanstList

  • Render test
  • Test conditional rendering
  • Snapshot test

@thatzacdavis thatzacdavis added frontend javascript Pull requests that update Javascript code labels Mar 22, 2020
@thatzacdavis thatzacdavis requested a review from medy-io March 22, 2020 01:16
@mariekers
Copy link
Collaborator

Hey @thatzacdavis any updates on this?

@thatzacdavis
Copy link
Collaborator Author

Hey @thatzacdavis any updates on this?

Not yet, had a lot of life and work changes happening recently.

medy-io
medy-io approved these changes May 10, 2020
View reviewed changes
Copy link
Collaborator

@medy-io medy-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is all awesome work Zach, this thing is gtg!!! We can talk about how we wanna break it down into smaller test files when I go to refactor the participant info page.

@thatzacdavis
Copy link
Collaborator Author

Closing this as the component was significantly refactored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@medy-io medy-io medy-io approved these changes

Assignees
No one assigned
Labels
frontend javascript Pull requests that update Javascript code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thatzacdavis @mariekers @medy-io