Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search project files for the Settings.bundle file #42

Merged
merged 2 commits into from
Feb 23, 2017

Conversation

jhildensperger
Copy link
Contributor

@jhildensperger jhildensperger commented Jan 24, 2017

I have my build directory in the same folder as my project and using Dir.glob("**/*Settings.bundle").first is matching the Settings.bundle file from a previous build.

This seems to fix the issue for my use case.

@ssuchanowski
Copy link

+1

@orta
Copy link
Member

orta commented Jan 31, 2017

Yeah, that seems good to me, thanks for the +1, I missed this

@jhildensperger can you add a CHANGELOG entry please? Other that that, it's good to go 👍

@jhildensperger jhildensperger force-pushed the bug/incorrect-settings-bundle branch from a9c9ad8 to b7fe628 Compare January 31, 2017 14:47
@leoformaggio
Copy link

Wondering if this is good to merge, it might fix #32 too

@orta
Copy link
Member

orta commented Feb 23, 2017

Ah yeah, sorry, didn't notice it was updated :D

@orta orta merged commit eadb277 into CocoaPods:master Feb 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants