This repository has been archived by the owner on Nov 3, 2020. It is now read-only.
Metadata extraction for Metadata Table View #215
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This started as an exercise to code-golf
flattenXcodeProjects(_:targets:)
after being poked by @nwest. I got this far:The more I used it, though, the more I realized that there are two things happening in this file: converting from a list of Xcode projects and a list of CocoaPods targets to an array of entries to display in a table view, and displaying metadata from that list to display in the table. Both of those tasks seemed well-suited to protocols. So, this PR creates two protocols:
CPMetadataExtractable
, which covers converting the two arrays into one array of metadata, andCPMetadataRepresentable
, which covers displaying the data in the table.This is a pretty big change, but it buys more type safety. Notice that
tableView(_:heightOfRow:)
andtableView(_: viewForTableColumn:row:)
no longer need to handle the “else” case of displaying nothing, since the array ofprojectMetadataEntries
is type-safe.Overall, in exchange for a net gain of 14 lines, we’ve gained a lot of safety. I think it’s a net positive.