Added missing test cases for submissions.py #202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing Test Cases for submissions.py
@lunayach , @Ram81 , @RishabhJain2018 , @vkartik97 ,I have added the missing test cases to the file indicated in the task. However, despite it getting 100% code coverage, the overall code coverage is 89%. I guess that might be a miscalculation.
The second thing is in order to add the test case for the missing schema. I had to move the code that catches the exception to the function where it is supposed to be as it was not getting called in its former position due to the fact that it was in the wrong function. I have fixed that now.
The new code I have provided has 100% coverage in the submissions test as I have written the remaining test cases.
The code does not break.
Please let me know if you have any comments.
Thank you