Chiragbaligci patch 4 #190
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
auth key and host id
add-command-CLI
Ram81
requested changes
Dec 8, 2019
| @click.option('--host') | ||
| def main(auth,host): | ||
|
|
||
|
|
| def main(auth,host): | ||
|
|
||
|
|
||
| a=click.prompt("AUTHENTICATION TOKEN") |
There was a problem hiding this comment.
Please rename variable names which are appropriate to the task
|
|
||
|
|
||
| a=click.prompt("AUTHENTICATION TOKEN") | ||
| h=click.prompt("HOST ID ") |
There was a problem hiding this comment.
Add space before and after =. Also remove trailing spaces in the click.prompt
| @@ -6,18 +6,18 @@ | |||
| from evalai.utils.auth import get_user_auth_token_by_login | |||
| from evalai.utils.config import AUTH_TOKEN_PATH, AUTH_TOKEN_DIR | |||
|
|
|||
| @click.command() | |||
|
|
|||
There was a problem hiding this comment.
Why is there a blank line in between?
|
@chiragbaligci also rename the PR title relevant to your task |
krtkvrm
reviewed
Dec 8, 2019
There was a problem hiding this comment.
Hi @chiragbaligci
Can you please modify the PR Description to be informative and give context of your work and changes that you are proposing to the codebase.
|
@chiragbaligci please close this PR as this one is redundant. |
|
Ok
Sent from Mail for Windows 10
From: Ram Ramrakhya
Sent: Sunday, December 8, 2019 2:27 PM
To: Cloud-CV/evalai-cli
Cc: chiragbaligci; Mention
Subject: Re: [Cloud-CV/evalai-cli] Chiragbaligci patch 4 (#190)
@chiragbaligci closing this PR as this one is redundant.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT NOTES (please read, then delete):
The PR title should start with "Fix #bugnum: " (if applicable), followed by a clear one-line present-tense summary of the changes introduced in the PR. For example: "Fix #bugnum: Introduce the first version of the collection editor.".
Please make sure to mention "#bugnum" somewhere in the description of the PR. This enables Github to link the PR to the corresponding bug.
Please also make sure to follow the style rules.