Fix for enhancement#1001: Google Code-in Task to update the error message #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sage Fix for enhancement#1000: Google Code-in Task to update the error message This is for Google Code-in Task. Updated the error message to add the URL of the API end point to the end of the existing error message. Currently it shows as " Please check the Host URL" and it is modified to add the host url at the end of this message. ex: if the CLI is not able to connect to https://api.evalai.example the error should be "Could not establish connection to EvalAI. Please check the Host URL: https://api.evalai.example".
…sage Fix for enhancement#1001: Google Code-in Task to update the error message This is for Google Code-in Task. Updated the error message to add the URL of the API end point to the end of the existing error message. Currently it shows as " Please check the Host URL" and it is modified to add the host url at the end of this message. ex: if the CLI is not able to connect to https://api.evalai.example the error should be "Could not establish connection to EvalAI. Please check the Host URL: https://api.evalai.example". As per the Mentor feedback, I fixed the host url to display only the host details.
Ram81
approved these changes
Dec 8, 2019
|
LGTM. nvm previous comment. 👍 |
Fix for enhancement#1002: Google Code-in Task to add a command Added a command for displaying the text from stdout file in terminal. Assuming the stdout file is located under ~/.evalai/stdout.txt. In order to test this functionality, create a sample stdout.txt file under ~/.evalai/. and issue the following command 'evalai display' will output the stdout.txt file's content.
incorrect task.
This reverts commit 50586da.
…a command"" This reverts commit c3a5dc6.
…R DOWNLOAD_FILE CLI COMMAND Fix for enhancement#1003: Google Code-in Task to ADD DOCUMENTATION FOR DOWNLOAD_FILE CLI COMMAND This is for Google Code-in Task. As per Mentor's feedback, I updated the docs/readme.md file to provide the steps how to to use the cli command for download_file . Please review the PR and merge it to the master branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for enhancement#1001: Google Code-in Task to update the error message
As per Mentor's feedback, I fixed the error message so that it only show the host details of the host url.
======
This is for Google Code-in Task. Updated the error message to add the URL of the API end point to the end of the existing error message. Currently it shows as " Please check the Host URL" and it is modified to add the host url at the end of this message. ex: if the CLI is not able to connect to https://api.evalai.example the error should be "Could not establish connection to EvalAI. Please check the Host URL: https://api.evalai.example".