Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #318: fixed datatype error #319

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Shivanshmundra
Copy link
Contributor

Fix #318: Fixed datatype error
This fixes the issue #318 Don't throw error when some specific parameters value is edited while model is exported. Checked by again importing the same model showing same values of edited parameters.

@coveralls
Copy link

coveralls commented Mar 1, 2018

Coverage Status

Coverage remained the same at 95.442% when pulling 4cb7455 on Shivanshmundra:floatTonumber into 062db16 on Cloud-CV:master.

@utsavgarg
Copy link
Contributor

@Shivanshmundra Thanks for reporting the bug and the fix. But the error seems to persist even after this. Steps to recreate:

  • Load ResNet-101 model from the model zoo
  • Change value of moving average fraction in the batch norm layer
  • Try exporting

@Ram81
Copy link
Member

Ram81 commented Mar 15, 2018

@Shivanshmundra it would be better to parse values at the time of layer update. If you need help with update part we can discuss.

@Shivanshmundra
Copy link
Contributor Author

@utsavgarg @Ram81 I figured out the error, Actually by default each value is parsed as string.
Now there is exception to parse value as integer but there was no exception for float so I added it and now its working fine.
Have a review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"str" error while editing some params value in layers
4 participants