Skip to content
This repository has been archived by the owner on Jul 6, 2020. It is now read-only.

Showing leaderboard precision value dynamically #285

Closed
wants to merge 5 commits into from
Closed

Showing leaderboard precision value dynamically #285

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
096f52d
leaderboard decimal precision
Feb 8, 2020
c9283e6
Link to documentation added
Feb 8, 2020
ddf1486
moved to branch
Feb 8, 2020
2bae6aa
Revert "Link to documentation added"
Feb 8, 2020
900faf7
Revert "moved to branch"
Feb 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/app/components/challenge/challengeleaderboard/challengeleaderboard.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@
</mat-chip-list>
</span>
</td>
<td *ngFor="let score of key.result">{{score | number : '1.2-2'}}</td>
<td *ngFor="let score of key.result">{{score | number : selectedPhaseSplit.leaderboard_decimal_precision}}</td>
<td><div>{{ key.submission__submitted_at_formatted }}</div></td>
</tr>
</tbody>
Expand Down
1 change: 1 addition & 0 deletions src/app/components/nav/header-static/header-static.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
<!-- show after authenticate user -->
<li *ngIf="authService.isAuth && !isDash"><a class="waves-effect waves-dark main-header-link" (click) ="isDash = true" routerLink="/dashboard" routerLinkActive="active">Dashboard</a></li>
<li *ngIf="authService.isAuth && isDash"><a class="waves-effect waves-dark main-header-link" routerLink="/challenges" routerLinkActive="active">All Challenges</a></li>
<li *ngIf="authService.isAuth"><a class="waves-effect waves-dark main-header-link" href="https://evalai.readthedocs.io/en/latest/" target="_blank">Docs</a></li>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was comparing the original evalai with evalai-ngx and found that the there is a link to the documentation in the navbar of original evalai code. So, i added this line to for the same functionality in evalai-ngx too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok but this isn't related to this pr so undo it please

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. I will create a different pr for this!

<li *ngIf="authService.isAuth"><a class="waves-effect waves-dark main-header-link" href="https://evalai-forum.cloudcv.org/" target="_blank">Forum</a></li>
</ul>
<ul class="right hide-on-med-and-down">
Expand Down