Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix check_mk_agent.openbsd multi network interfaces support #757

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

coreidcc
Copy link

current behaviour: the script work well if there is only one network interface configured but as soon as more then one network interface exists the reports just garbage.

the cause: seeting IFS to '' will skip any substitution resulting in for loop only executing once (the list to iterate over just consists of a single value)

solution: set IFS to only contain a newline

Thank you for your interest in contributing to Checkmk!
Consider looking into Readme regarding process details.

General information

Please give a brief summary of the affected device, software or appliance.
Keep in mind that we are experts in monitoring, but we cannot be experts on all supported devices.
A little context will help us assess your proposed change.

Bug reports

Please include:

  • Your operating system name and version
  • Any details about your local setup that might be helpful in troubleshooting
  • Detailed steps to reproduce the bug
  • An agent output or SNMP walk
  • The ID of a submitted crash report for reference (if applicable)

Proposed changes

Sometimes it is hard for us to assess the quality of a fix.
While it may work for you, it is our job to ensure that it works for everybody.
These are some ways to help us:

  • What is the expected behavior?
  • What is the observed behavior?
  • If it's not obvious from the above: In what way does your patch change the current behavior?
  • Consider writing a unit test that would have failed without your fix.
  • Is this a new problem? What made you submit this PR (new firmware, new device, changed device behavior)?

Copy link

github-actions bot commented Sep 23, 2024

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@coreidcc
Copy link
Author

I have read the CLA Document and I hereby sign the CLA or my organization already has a signed CLA.

current behaviour: the script work well if there is only
one network interface configured but as soon as more then
one network interface exists the reports just garbage.

the cause: seeting IFS to '' will skip any substitution
resulting in for loop only executing once (the list to
iterate over just consists of a single value)

solution: set IFS to only contain a newline
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants