Implement service state filter for quicksearch widget #713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moschlar
force-pushed
the
quicksearch-state
branch
from
35da0bd to
c8f5960
Compare
|
This PR is stale because it has been open for 14 days with no activity and the Github Actions are not passing. |
This comment was marked as resolved.
This comment was marked as resolved.
|
This PR is stale because it has been open for 14 days with no activity and the Github Actions are not passing. |
github-actions
bot
added
Stale
moschlar
force-pushed
the
quicksearch-state
branch
5 times, most recently
from
27c8d96 to
e00ed14
Compare
moschlar
force-pushed
the
quicksearch-state
branch
from
90c2a21 to
2ebcad8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
General information
I use the quicksearch sidebar widget a lot and I often find myself wanting to see all services matching a description that are not OK - so I thought it would be nice to have an additional filter so that I can query for e.g.
s:Certificate st:1 st:2.Proposed changes
I implemented a
ServiceStateMatchPluginclass to accomplish this - it works quite well now!Open tasks/questions:
get_matchessupposed to be?(See previous PR at #587)