Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace system table query with system catalog views query #651

Closed

Conversation

fabiozanella
Copy link

General information

From Microsoft documentation:

You should not code Transact-SQL statements that directly query the system tables, unless that is the only way to obtain the information that is required by the application. Instead, applications should obtain catalog and system information by using the following:

  • System catalog views
  • SQL-SMO
  • Windows Management Instrumentation (WMI) interface
  • Catalog functions, methods, attributes, or properties of the data API used in the application, such as ADO, OLE DB, or ODBC.
  • Transact-SQL system stored procedures and built-in functions.

Proposed changes

As specified in the Microsoft documentation I replaced the direct query on the system tables with the appropriate view

  • What is the expected behavior?
    Exactly like before
  • What is the observed behavior?
    Exactly like before
  • If it's not obvious from the above: In what way does your patch change the current behavior?
    Replace system table query with System catalog views query

I have read the CLA Document and I hereby sign the CLA or my organization already has a signed CLA.

@fabiozanella fabiozanella marked this pull request as ready for review December 5, 2023 11:39
@fabiozanella fabiozanella changed the title Replace system table query with System catalog views query Replace system table query with system catalog views query Dec 5, 2023
@scolakovic scolakovic added the enhancement New feature or request label Jan 5, 2024
@fabiozanella fabiozanella force-pushed the dont-use-system-table branch 2 times, most recently from 7fe1b7a to 1e7c9f3 Compare April 12, 2024 13:14
@CheckmkCI CheckmkCI force-pushed the master branch 2 times, most recently from 875a494 to 3419412 Compare May 29, 2024 08:27
@CheckmkCI CheckmkCI closed this Jun 19, 2024
@TimotheusBachinger
Copy link
Contributor

Dear Checkmk Contributor! Unfortunately, we had to re-write our git-repo history, rendering your PR auto-closed. We will therefore rebase your PR onto the current master and reopen it again. Sorry for the inconvenience.

@TimotheusBachinger
Copy link
Contributor

Dear Contributor. Unfortunately, we learned that re-opening a PR which was force-rebased, is not possible (see isaacs/github#361). Therefore we kindly ask you to create a new PR for your change. We apologize for the circumstances and will implement technical measures to prevent such incidents in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tracked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants