Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Pure Storage FA Agent] Add UserAgent string #616

Closed
wants to merge 2 commits into from

Conversation

sdodsley
Copy link
Contributor

@sdodsley sdodsley commented Aug 4, 2023

General information

Pure Storage monitors 3rd party integrations that access API endpoints through dial-home technology.
The preferred way of doing this is to provide a User-Agent string.

Proposer is Director of Open Source Integrations at Pure Storage

Proposed changes

Add a User-Agent string in the API call header.

@github-actions
Copy link

github-actions bot commented Aug 4, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@sdodsley
Copy link
Contributor Author

sdodsley commented Aug 4, 2023

I have read the CLA Document and I hereby sign the CLA or my organization already has a signed CLA.

Copy link
Member

@mo-ki mo-ki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Simon,
Thanks for your interest and PR! A small change and we can merge this.

cmk/special_agents/agent_pure_storage_fa.py Show resolved Hide resolved
@mo-ki
Copy link
Member

mo-ki commented Oct 23, 2023

Ah, sorry. I just realized that's what you did in your earlier commit. I'll merge that then!
Thanks again!

@CheckmkCI CheckmkCI closed this in 3ddf5aa Oct 24, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2023
@sdodsley sdodsley deleted the pure_fa_user-agent branch October 24, 2023 12:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants