Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

monitor nginx_status endpoint even if has invalid ssl #604

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

ITJamie
Copy link
Contributor

@ITJamie ITJamie commented Jun 28, 2023

General information

the existing code would fail if it attempted to monitor a site with an invalid SSL cert (eg https://localhost)
a cert expiry would also stop monitoring

Bug reports

output before code change

./nginx_status.py
<<<nginx_status>>>
Exception (127.0.0.1:443): <urlopen error [SSL: CERTIFICATE_VERIFY_FAILED] certificate verify failed: IP address mismatch, certificate is not valid for '127.0.0.1'. (_ssl.c:1129)>

Proposed changes

code changes skips cert validation
result:

./nginx_status.py
<<<nginx_status>>>
127.0.0.1 443 Active connections: 5
127.0.0.1 443 server accepts handled requests
127.0.0.1 443  718 718 3030
127.0.0.1 443 Reading: 0 Writing: 1 Waiting: 4

monitor nginx_status endpoint even if has invalid ssl
@github-actions
Copy link

github-actions bot commented Jun 28, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@ITJamie
Copy link
Contributor Author

ITJamie commented Jun 28, 2023

I have read the CLA Document and I hereby sign the CLA or my organization already has a signed CLA.

@ITJamie
Copy link
Contributor Author

ITJamie commented Jun 28, 2023

recheck

@si-23 si-23 added bug Something isn't working Component: Checks & Agents labels Sep 27, 2023
@mo-ki mo-ki merged this pull request into Checkmk:master Oct 20, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Oct 20, 2023
@mo-ki
Copy link
Member

mo-ki commented Oct 20, 2023

Hm. I might have accidentally merged this, in which case it should automatically be overwritten soonish, which is why we're not supposed to do that. Let's see what happens. Feel free to open another PR if this does not end well :-| .

@mo-ki
Copy link
Member

mo-ki commented Oct 22, 2023

Yeah, it's gone. I'm sincerely sorry about that. You're welcome to re-open -- maybe compare to apache_status and also have a look at #246!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working Component: Checks & Agents
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants