17480 FIX missing agent output for mk_db2

SUP-20798 Closes: #761 Co-authored-by: Logan Connolly <[email protected]> Change-Id: I9051a84cc1595f0780b0a8cb5704f875cd9f8ea3
Checkmk · Dec 12, 2024 · daf350e · daf350e
1 parent 441add9
commit daf350e
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 4 deletions.
diff --git a/.werks/17480.md b/.werks/17480.md
@@ -0,0 +1,16 @@
+[//]: # (werk v2)
+# Fix empty output from mk_db2 agent
+
+key        | value
+---------- | ---
+date       | 2024-12-11T13:55:20+00:00
+version    | 2.3.0p23
+class      | fix
+edition    | cre
+component  | checks
+level      | 1
+compatible | yes
+
+The `mk_db2.aix` agent plugin generated empty output for AIX 7.2.
+
+This fix resolves the issue.
diff --git a/agents/plugins/mk_db2.aix b/agents/plugins/mk_db2.aix
@@ -1,4 +1,4 @@
-#!/usr/bin/ksh
+#!/usr/bin/ksh93
 # Copyright (C) 2019 Checkmk GmbH - License: GNU General Public License v2
 # This file is part of Checkmk (https://checkmk.com). It is subject to the terms and
 # conditions defined in the file COPYING, which is part of this source code package.
@@ -65,11 +65,11 @@ function waitmax {
 function query_instance {
     INSTANCE=$1
     # find home directory
-    HOMEDIR=$(grep "^$INSTANCE" /etc/passwd | awk -F: '{print $6}' | grep "$INSTANCE$")
+    HOMEDIR=$(grep -w "^$INSTANCE:" /etc/passwd | awk -F: '{print $6}')
     NOW=$(perl -e "print time();")
 
     waitmax 200 <<WAITMAX
-    su $INSTANCE << EOF
+    su - $INSTANCE -c "/usr/bin/ksh93" << EOF
 
     if [ ! -f $HOMEDIR/sqllib/db2profile ] ;
     then
@@ -99,7 +99,7 @@ function query_instance {
     DB_PORT='port 0'
     for DB in \\\$DBS; do
             db2 connect to \\\$DB > /dev/null;
-            if [ $? -nq 0 ] ; then
+            if [ $? -ne 0 ] ; then
                 exit 1
             fi