Skip to content

Commit

Permalink
17550 FIX Fix webauthn incorrectly displaying error message on login
Browse files Browse the repository at this point in the history
When using the webauthn functionaility for two factor within Checkmk,
an error would previously display on successful login.

This error did not impact the use of this functionaility but was not
intended to be displayed.

Change-Id: I27c0e45aff2e722022b5d54b60b8f4c6e61e6a9d
  • Loading branch information
Zatcmk authored and Shortfinga committed Jan 16, 2025
1 parent 20ec972 commit b57ccab
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 1 deletion.
18 changes: 18 additions & 0 deletions .werks/17550.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
[//]: # (werk v2)
# Fix webauthn incorrectly displaying error message on login

key | value
---------- | ---
date | 2025-01-15T08:19:09+00:00
version | 2.3.0p25
class | fix
edition | cre
component | wato
level | 1
compatible | yes

When using the webauthn functionaility for two factor within Checkmk,
an error would previously display on successful login.

This error did not impact the use of this functionaility but was not
intended to be displayed.
3 changes: 2 additions & 1 deletion cmk/gui/wato/pages/user_profile/two_factor.py
Original file line number Diff line number Diff line change
Expand Up @@ -1084,5 +1084,6 @@ def page(self) -> JsonSerializable:
raise

session.session_info.webauthn_action_state = None
handle_success_auth(user.id)
session.session_info.two_factor_completed = True
save_custom_attr(user.id, "num_failed_logins", 0)
return {"status": "OK"}

0 comments on commit b57ccab

Please sign in to comment.