Skip to content

Commit

Permalink
pylint
Browse files Browse the repository at this point in the history
* fix:  Consider iterating the dictionary directly instead of calling .keys() (consider-iterating-dictionary)
* add pydantic-pylint plugin: this plugin makes @field_validator, etc. to @classmethod equivalents

Change-Id: I42b5e6c45901a6d509be21ace6ba80155c2d260e
  • Loading branch information
Christoph Rauch committed Nov 16, 2023
1 parent d72f364 commit 8677d5c
Show file tree
Hide file tree
Showing 3 changed files with 2,031 additions and 75 deletions.
3 changes: 2 additions & 1 deletion .pylintrc
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ load-plugins=
tests.testlib.pylint_checker_forbidden_objects,
tests.testlib.pylint_checker_cmk_module_layers,
tests.testlib.pylint_checker_layering_violation,
pylint.extensions.bad_builtin
pylint.extensions.bad_builtin,
pylint_pydantic
jobs=0
# pickle collected data for later comparisons. Not used in our CI and makes runs faster
persistent=no
Expand Down
1 change: 1 addition & 0 deletions Pipfile
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ pexpect = "*" # used for update testing
dill = "*"
jsonschema = "*"
polyfactory = "*" # used for generating mock data for unit tests
pylint-pydantic = "*"
checkmk-dev-tools = "==0.1.24" # provides tooling for build artifacts
fastapi = "*" # needed to run fake idp for cse tests
uvicorn = "*"
Expand Down
Loading

0 comments on commit 8677d5c

Please sign in to comment.