Reland "Move mypy config from agent-based pyproject.toml to root"

This reverts commit 0c589fd24da1af2cf04fa774ee177d44e5f7b3e1.

Change-Id: Ife5e724dc7d437d54316518d01522d558398c878

packages/cmk-agent-based/BUILD

@@ -9,6 +9,10 @@ load("@rules_mypy//mypy:mypy.bzl", "mypy_cli")
 mypy_cli(
     name = "mypy_cli",
     mypy_requirement = requirement("mypy"),
+    deps = [
+        # for `plugins = ["pydantic.mypy"]`
+        requirement("pydantic"),
+    ],
 )
 
 exports_files([

packages/cmk-agent-based/aspects.bzl

@@ -2,6 +2,6 @@ load("@rules_mypy//mypy:mypy.bzl", "mypy")
 
 mypy_aspect = mypy(
     mypy_cli = "@@//packages/cmk-agent-based:mypy_cli",
-    mypy_ini = "@@//packages/cmk-agent-based:pyproject.toml",
+    mypy_ini = "@@//:pyproject.toml",
     suppression_tags = ["no-mypy"],
 )

packages/cmk-agent-based/cmk/agent_based/prediction_backend.py

@@ -18,19 +18,19 @@
 _ONE_DAY = 24 * 3600
 
 
-class PredictionParameters(BaseModel, frozen=True):  # type: ignore[misc]  # hidden Any
+class PredictionParameters(BaseModel, frozen=True):
     period: Literal["wday", "day", "hour", "minute"]
     horizon: int
     levels: tuple[Literal["absolute", "relative", "stdev"], tuple[float, float]]
     bound: tuple[float, float] | None = None
 
 
-class InjectedParameters(BaseModel, frozen=True):  # type: ignore[misc]  # hidden Any
+class InjectedParameters(BaseModel, frozen=True):
     meta_file_path_template: str
     predictions: Mapping[int, tuple[_Prediction | None, _EstimatedLevels | None]]
 
 
-class PredictionInfo(BaseModel, frozen=True):  # type: ignore[misc]  # hidden Any
+class PredictionInfo(BaseModel, frozen=True):
     valid_interval: tuple[int, int]
     metric: str
     direction: _Direction

packages/cmk-agent-based/pyproject.toml

@@ -36,39 +36,9 @@ ignore = [
 #[tool.ruff.lint.isort]
 # see ruff.toml for the isort section
 
-[tool.mypy]
-follow_imports = "silent"
-follow_imports_for_stubs = true
-enable_error_code = [
-  "explicit-override",
-  "ignore-without-code",
-  "mutable-override",
-  "possibly-undefined",
-  # Neeeds to be investigated
-  #"redundant-expr",
-  "redundant-self",
-  "truthy-bool",
-  "truthy-iterable",
-  "unimported-reveal",
-  "unused-awaitable",
-  "unused-ignore",
-]
-explicit_package_bases = true
-packages = ["cmk", "tests"]
-strict = true
-# Miscellaneous stuff not in --strict
-disallow_any_decorated = true
-disallow_any_explicit = true
-disallow_any_expr = true
-disallow_any_generics = true
-disallow_any_unimported = true
-disallow_subclassing_any = true
-no_implicit_optional = true
-strict_optional = true
-warn_unreachable = true
-# hidden flags for PEP 688 compat, see https://github.com/python/mypy/issues/15313
-disable_bytearray_promotion = true
-disable_memoryview_promotion = true
+# [tool.mypy]
+# Configure under the corresponding [[tool.mypy.overrides]] array
+# in the root `pyproject.toml`.
 
 [tool.pytest.ini_options]
 consider_namespace_packages = true

packages/cmk-agent-based/tests/cmk/agent_based/v1/test_checking_classes.py

@@ -15,7 +15,7 @@
 
 def test_evalable_float() -> None:
     inf = _EvalableFloat("inf")
-    assert literal_eval(f"{inf!r}") == float("inf")  # type: ignore[misc]
+    assert literal_eval(f"{inf!r}") == float("inf")
 
 
 def test_service_label() -> None:
@@ -93,7 +93,7 @@ def test_state() -> None:
     assert State["UNKNOWN"] is State.UNKNOWN
 
     with pytest.raises(TypeError):
-        _ = State.OK < State.WARN  # type: ignore[operator,misc]
+        _ = State.OK < State.WARN  # type: ignore[operator]
 
 
 @pytest.mark.parametrize(

pyproject.toml

@@ -127,6 +127,10 @@ plugins = ["pydantic.mypy"]
 python_version = "3.12"
 scripts_are_modules = true
 
+# do not descend into 3rd party dependencies
+follow_imports = "silent"
+follow_imports_for_stubs = true
+
 # hidden flags for PEP 688 compat, see https://github.com/python/mypy/issues/15313
 disable_bytearray_promotion = true
 disable_memoryview_promotion = true
@@ -302,6 +306,34 @@ disallow_untyped_calls = true
 disallow_untyped_defs = true
 warn_unreachable = true
 
+[[tool.mypy.overrides]]
+module = "cmk.agent_based.*"
+strict = true
+enable_error_code = [
+  "explicit-override",
+  "ignore-without-code",
+  "mutable-override",
+  "possibly-undefined",
+  # Needs to be investigated
+  # "redundant-expr",
+  "redundant-self",
+  "truthy-bool",
+  "truthy-iterable",
+  "unimported-reveal",
+  "unused-awaitable",
+  "unused-ignore",
+]
+# Miscellaneous stuff not in --strict
+disallow_any_decorated = true
+disallow_any_explicit = true
+disallow_any_expr = true
+disallow_any_generics = true
+disallow_any_unimported = true
+disallow_subclassing_any = true
+no_implicit_optional = true
+strict_optional = true
+warn_unreachable = true
+
 [tool.pydantic-mypy]
 init_forbid_extra = true
 init_typed = true