Skip to content

Commit

Permalink
Do not use store_automation_secret in site fixture
Browse files Browse the repository at this point in the history
This parameter was not available in older versions so it caused problems
in out update tests since we use the same fixture for older versions as
well.
Since we used only the default anyways, let's not set it...

Change-Id: I3e76c2888b177d1903d38dc22956b8a92c7e2fd9
  • Loading branch information
Shortfinga authored and MatteoStifano committed Dec 20, 2024
1 parent 851dbce commit 2dd3b1e
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 4 deletions.
1 change: 0 additions & 1 deletion tests/integration/cmk/gui/test_login.py
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ def create_and_delete_automation_user(site: Site) -> Iterator[tuple[str, str]]:
contactgroups=[],
roles=["user"],
is_automation_user=True,
store_automation_secret=False,
)
try:
yield username, password
Expand Down
2 changes: 0 additions & 2 deletions tests/testlib/openapi_session.py
Original file line number Diff line number Diff line change
Expand Up @@ -325,13 +325,11 @@ def create(
customer: None | str = None,
roles: list[str] | None = None,
is_automation_user: bool = False,
store_automation_secret: bool = False,
) -> None:
if is_automation_user:
auth_option = {
"auth_type": "automation",
"secret": password,
"store_automation_secret": store_automation_secret,
}
else:
auth_option = {
Expand Down
1 change: 0 additions & 1 deletion tests/testlib/site.py
Original file line number Diff line number Diff line change
Expand Up @@ -1146,7 +1146,6 @@ def _create_automation_user(self) -> None:
contactgroups=[],
roles=["admin"],
is_automation_user=True,
store_automation_secret=False,
)
self.openapi.set_authentication_header(user=username, password=self._automation_secret.raw)

Expand Down

0 comments on commit 2dd3b1e

Please sign in to comment.