Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #531: Folder network_scan_result #648

Merged
merged 2 commits into from
Aug 14, 2024
Merged

Fix #531: Folder network_scan_result #648

merged 2 commits into from
Aug 14, 2024

Conversation

lgetwan
Copy link
Contributor

@lgetwan lgetwan commented Aug 14, 2024

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #531

What is the new behavior?

  • Even with a network scan result present, the "update attributes" works fine

@lgetwan lgetwan added bug Something isn't working module:folder This affects the folder module labels Aug 14, 2024
@lgetwan lgetwan self-assigned this Aug 14, 2024
@lgetwan lgetwan requested a review from robin-checkmk August 14, 2024 11:01
@lgetwan lgetwan mentioned this pull request Aug 14, 2024
Closed
robin-checkmk
robin-checkmk approved these changes Aug 14, 2024
View reviewed changes
Copy link
Member

@robin-checkmk robin-checkmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks trivial and works as intended now. Nice!

@robin-checkmk robin-checkmk linked an issue Aug 14, 2024 that may be closed by this pull request
[BUG] update_attributes on folder with network scan enabled (and a network scan result present) fails #531
Closed
@robin-checkmk robin-checkmk merged commit 6ed8a5b into devel Aug 14, 2024
42 checks passed
@robin-checkmk robin-checkmk deleted the fix/531-folder-network-scan-result branch August 14, 2024 12:00
@github-actions github-actions bot locked and limited conversation to collaborators Aug 14, 2024
@robin-checkmk robin-checkmk added the release:5.2.1 Affects the mentioned release. label Aug 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@robin-checkmk robin-checkmk robin-checkmk approved these changes

Assignees

@lgetwan lgetwan

Labels
bug Something isn't working module:folder This affects the folder module release:5.2.1 Affects the mentioned release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] update_attributes on folder with network scan enabled (and a network scan result present) fails
2 participants
@lgetwan @robin-checkmk