-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebuild tests using Checkmk containers #624
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-collection-checkmk.general into build/overhaul-int-tests
…ible-collection-checkmk.general into build/overhaul-int-tests
…ible-collection-checkmk.general into build/overhaul-int-tests
lgetwan
reviewed
Oct 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a lot of work!
I think I didn't get how the whole thing went into containers, based on the information I have here (changed files).
lgetwan
approved these changes
Oct 30, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
documentation
Improvements or additions to documentation
enhancement
New feature or request
module:downtime
This affects the downtime module
module:folder
This affects the folder module
module:tag_group
This affects the tag_group module
never-stale
This issue never becomes stale. Used for reminder issues and similar.
role:agent
This affects the agent role
role:server
This affects the server role
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
We currently use the default container with
ansible-test
and install Checkmk into it on every test run.This is not only lengthy, but has repercussions, e.g., just recently the OS of that container was bumped to a new version, breaking some of our test.
What is the new behavior?
We use the GitHub Actions
services:
keyword, to start native Checkmk containers to run our tests against.Other information
This is a work in progress!
ToDo: