Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild tests using Checkmk containers #624

Merged
merged 121 commits into from
Nov 11, 2024
Merged

Conversation

robin-checkmk
Copy link
Member

@robin-checkmk robin-checkmk commented Jun 13, 2024

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

We currently use the default container with ansible-test and install Checkmk into it on every test run.
This is not only lengthy, but has repercussions, e.g., just recently the OS of that container was bumped to a new version, breaking some of our test.

What is the new behavior?

We use the GitHub Actions services: keyword, to start native Checkmk containers to run our tests against.

Other information

This is a work in progress!

ToDo:

@robin-checkmk robin-checkmk self-assigned this Jun 13, 2024
@robin-checkmk robin-checkmk marked this pull request as ready for review October 17, 2024 08:49
Copy link
Contributor

@lgetwan lgetwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a lot of work!
I think I didn't get how the whole thing went into containers, based on the information I have here (changed files).

@robin-checkmk robin-checkmk merged commit cbfcbbf into devel Nov 11, 2024
24 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 11, 2024
@robin-checkmk robin-checkmk deleted the build/overhaul-int-tests branch November 11, 2024 14:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation enhancement New feature or request module:downtime This affects the downtime module module:folder This affects the folder module module:tag_group This affects the tag_group module never-stale This issue never becomes stale. Used for reminder issues and similar. role:agent This affects the agent role role:server This affects the server role
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants