Feature/uu course descriptions #1722
Conversation
lukavdplas
added
the
affects-deployment
| corpus = corpus_from_api(admin_client) | ||
| assert corpus['title'] == 'All faculties' | ||
|
|
||
| goal = '''- Begrijpen van de functie van testen in software. |
| '-': None, | ||
| } | ||
|
|
||
| def get_from(mapping: Mapping) -> Callable: |
There was a problem hiding this comment.
consider using a more descriptive function name, like 'transform_from_dictionary'
| } | ||
|
|
||
| LEVELS = { | ||
| 1: 'Bachelor 1', |
There was a problem hiding this comment.
The transform doesn't work for the keys of this dict that are integers: levels are still shown as '1', '2', '3' instead of 'Bachelor 1'.
| extractor=CSV('OMSCHRIJVING'), | ||
| es_mapping=keyword_mapping(enable_full_text_search=True), | ||
| results_overview=True, | ||
| search_filter=MultipleChoiceFilter(option_count=100), |
There was a problem hiding this comment.
This filter doesn't seem to show up on the web version of course explorer...
| return lambda doc: doc['faculty'] == FACULTIES[faculty.upper()] | ||
|
|
||
|
|
||
| class _UUCourseDescriptionsFaculty(UUCourseDescriptions): |
There was a problem hiding this comment.
I really like this implementation of subcorpora!
| * necessary if the app name already includes "i-analyzer" | ||
| */ | ||
| get showIAnalyzerInBrand() { | ||
| return ! this.appName.toLowerCase().includes('i-analyzer'); |
There was a problem hiding this comment.
I like the solution stylistically, but I don't know if this is the best way to implement naming conventions. I would either add some documentation explaining how the naming of apps works and how a developer should use those values, or just give two fields in the environment for Main app name and Secondary App name or something? Or is this meant to enforce that we have the I-analyzer name present at all times? :p
Adds several corpora with UU course descriptions.
I've kept the old "humanities course descriptions" corpus, because that one uses a slightly different data format. That corpus is kept the same, but uses the same picture as the "updated" version.
Because these corpora are created for a separate server, there are a few minor changes to the frontend to configure the server in
environment.ts:appNamethat is configuredServer configuration changes
If a server was using the
hum_course_descriptionscorpus, it must update the location of the source file. It's now located in theuu_course_descriptionsmodule.