Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-6470] Withdrawn version picker #2436

Conversation

futa-ikeda
Copy link
Contributor

@futa-ikeda futa-ikeda commented Dec 23, 2024

Purpose

  • Add a version select dropdown to the tombstone page

Summary of Changes

  • Add dropdown to tombstone page header to view prior versions
  • Update tests

Screenshot(s)

image

Side Effects

QA Notes

@futa-ikeda futa-ikeda force-pushed the withdrawn-version-picker branch from 1ae93c6 to f109ead Compare December 26, 2024 16:26
Copy link
Collaborator

@cslzchen cslzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified locally, works as expected.

One observations:

  • I think product want us to display the current version in the dropdown as well. I will check with them to see if we should add some indicator of which is the current version.

Screenshot 2024-12-27 at 10 02 14

Two out-of-scope bug which I can create a new ticket for you:

  • For the details page, I see the version numbers, nice. However, it doesn't redirect to the version when I select one.

Screenshot 2024-12-27 at 10 04 06

In addition, if I go to any version, the dropdown choice defaults the the latest version

Screenshot 2024-12-27 at 10 12 46

@futa-ikeda
Copy link
Contributor Author

Re: indicator for the current version, I will go ahead and add that now

Re: Preprint DOI dropdown, I will address those issues in a different PR. On that note, I agree that the Preprint DOI dropdown should have the currently viewed version selected by default, but I am wondering if selecting a different version in the Preprint DOI dropdown should redirect or not, if its purpose is to just show the DOI for different versions? It might be annoying if users just want to see the DOI for the different version and the page reloads when they select a version. May be a question for product team though

Copy link
Collaborator

@cslzchen cslzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎆

Screenshot 2024-12-27 at 13 38 00

@futa-ikeda futa-ikeda merged commit 6a62967 into CenterForOpenScience:feature/preprints-doi-versioning Dec 30, 2024
9 checks passed
@futa-ikeda futa-ikeda deleted the withdrawn-version-picker branch December 30, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants