Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENG-6559] Download feature for SHARE data #2415

Conversation

futa-ikeda
Copy link
Contributor

@futa-ikeda futa-ikeda commented Nov 26, 2024

Purpose

  • Allow users to download projects/registrations/preprints info in institutional dashboard

Summary of Changes

  • Add functionality to download from SHARE using the acceptMediatype and withFileName query-params

Screenshot(s)

  • For this filter set (where license is a boolean filter)...
    image
    ... the CSV download link would look like
https://staging-share.osf.io/trove/index-card-search
?acceptMediatype=text/csv
&withFileName=projects-search-results
&cardSearchFilter[affiliation]=http://ror.org/has-users
&cardSearchFilter[resourceType]=Project
&cardSearchFilter[rights][is-present]=true
&cardSearchFilter[funder]=http://dx.doi.org/10.10000/505000005050,https://doi.org/10.10000/100000001
&page[cursor]=&page[size]=10000&sort=-dateModified

Side Effects

QA Notes

@futa-ikeda futa-ikeda changed the title [WIP[ENG-6559] Download feature for SHARE data [WIP][ENG-6559] Download feature for SHARE data Nov 26, 2024
@futa-ikeda futa-ikeda force-pushed the share-download-integration branch from 404b5cd to 7360a10 Compare November 27, 2024 16:06
@futa-ikeda futa-ikeda changed the title [WIP][ENG-6559] Download feature for SHARE data [ENG-6559] Download feature for SHARE data Nov 27, 2024
@futa-ikeda futa-ikeda changed the title [ENG-6559] Download feature for SHARE data [WIP][ENG-6559] Download feature for SHARE data Nov 27, 2024
@futa-ikeda futa-ikeda changed the title [WIP][ENG-6559] Download feature for SHARE data [ENG-6559] Download feature for SHARE data Dec 2, 2024
@futa-ikeda futa-ikeda requested a review from aaxelb December 2, 2024 15:26
Copy link
Contributor

@aaxelb aaxelb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! found a small way to simplify, but it's not a problem

@futa-ikeda futa-ikeda merged commit 388d8ae into CenterForOpenScience:feature/dashboard-b-and-i Dec 2, 2024
9 checks passed
@futa-ikeda futa-ikeda deleted the share-download-integration branch December 2, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants