Bug/sc 458619/allow negative values on most common approx #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rantolin
force-pushed
the
bug/sc-458619/allow-negative-values-on-most-common-approx
branch
from
e76d76c to
ec74108
Compare
cayetanobv
requested changes
Jan 9, 2025
raster_loader/io/common.py
Outdated
| try: | ||
| _sum = int(np.sum(samples_band)) | ||
| except OverflowError: | ||
| _sum = float("inf") |
There was a problem hiding this comment.
2 questions:
- why is
infthe result of the sum in that geotiff? - Why do we want to set the value as
infwhen the overflow error rises? I know that the result isinfbut, is it useful? isn't it betterNoneor zero? if you set the sum as inf in the next append iteration the result will be inf again...
There was a problem hiding this comment.
The inf results is due to the fact that the testing geotiff has changed the nodata parameter to 0 but not having changed the actual nodata cell values that remain set to -3.4028230607370965e+38.
I have already changed this and now _sum and sum_squares are set to 0 when the sum is overflown.
rantolin
force-pushed
the
bug/sc-458619/allow-negative-values-on-most-common-approx
branch
from
ec74108 to
46cab53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This PR fixes these two bugs:
Proposed Changes
Changes fix two bugs related to computation of approximate stats:
OverflowErrorwhensumis infinity. We now catch this error and handle it.most_common_approxwhich is now usingnumpy.histogramto support the computation of approximate most common negative integer valuesPull Request Checklist