Refactor/render top toolbar

[PVautour]

Description

Move top toolbar rendering into a separate file for improved readability and performance gains in dev.

Fixes # (issue)

Type of change

• refactor
• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

https://pvautour.github.io/geoview/outlier-ESRI-maxRecordCount.html

Checklist:

• I have build (rush build) and deploy (rush host) my PR
• I have connected the issues(s) to this PR
• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• My changes generate no new warnings
• I have created new issue(s) related to the outcome of this PR is needed
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes

---

This change is 

[jolevesq]

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @DamonU2 and @PVautour)

---

packages/geoview-aoi-panel/src/aoi-panel.tsx line 1 at r1 (raw file):

/* eslint react/prop-types: 0 */

I am a bit scare to enter a modification for a build that is working for everybody else....

---

packages/.eslintrc line 35 at r1 (raw file):

  },
  "rules": {
    "react/prop-types": "off",

Why have you added this?

[jolevesq]

Click on hide column turn off visibility but toggle tays on

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @DamonU2 and @PVautour)

[DamonU2]

Reviewed 4 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @PVautour)

---

packages/geoview-aoi-panel/src/aoi-panel.tsx line 1 at r1 (raw file):

/* eslint react/prop-types: 0 */

Is this necessary if we're turning it off in the config file? Also, should we be turning it off in the config file?

[jolevesq]

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @DamonU2 and @PVautour)

---

packages/geoview-aoi-panel/src/aoi-panel.tsx line 1 at r1 (raw file):

Previously, DamonU2 (Damon Ulmi) wrote…

Is this necessary if we're turning it off in the config file? Also, should we be turning it off in the config file?

What do you mean @DamonU2 by turning it off from config?

[PVautour]

packages/geoview-aoi-panel/src/aoi-panel.tsx line 1 at r1 (raw file):

Previously, jolevesq (Johann Levesque) wrote…

What do you mean @DamonU2 by turning it off from config?

Damon you are correct this does not need to be here. It is redundant.

[PVautour]

packages/.eslintrc line 35 at r1 (raw file):

Previously, jolevesq (Johann Levesque) wrote…

Why have you added this?

Here is a snippet from the official react upgrade guide:

Removed: propTypes and defaultProps for functions

PropTypes were deprecated in April 2017 (v15.5.0).

In React 19, we’re removing the propType checks from the React package, and using them will be silently ignored. If you’re using propTypes, we recommend migrating to TypeScript or another type-checking solution.

We’re also removing defaultProps from function components in place of ES6 default parameters. Class components will continue to support defaultProps since there is no ES6 alternative.

Source: https://react.dev/blog/2024/04/25/react-19-upgrade-guide#removed-proptypes-and-defaultprops

Is it ok if I disable it even if we are on 18? It's deprecated anyway.