Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(csv): fixes issues with characters in csv headers breaking filter #2693

Conversation

DamonU2
Copy link
Member

@DamonU2 DamonU2 commented Jan 15, 2025

Closes #2653

Description

Replaces some values in CSV headers that break the filter strings. Also updates demo-osdp-integration.html documentation.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

https://damonu2.github.io/geoview/demos-navigator.html?config=./configs/navigator/23-csv.json

Problems were in NPRI layer

Checklist:

  • I have build (rush build) and deploy (rush host) my PR
  • I have connected the issues(s) to this PR
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have created new issue(s) related to the outcome of this PR is needed
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

This change is Reviewable

@DamonU2 DamonU2 requested a review from jolevesq January 15, 2025 20:20
@DamonU2 DamonU2 self-assigned this Jan 15, 2025
Copy link
Member

@jolevesq jolevesq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 3 files at r1, all commit messages.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @DamonU2)


packages/geoview-core/src/geo/layer/geoview-layers/vector/abstract-geoview-vector.ts line 432 at r1 (raw file):

    }

    parsedData[0].forEach((header, i) => {

CAn you add a comment about why we need this. You can even relate the issue number.

@DamonU2 DamonU2 force-pushed the 2653-french-character-filter branch from 7cedae5 to 235896e Compare January 16, 2025 15:17
Copy link
Member Author

@DamonU2 DamonU2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @DamonU2 and @jolevesq)


packages/geoview-core/src/geo/layer/geoview-layers/vector/abstract-geoview-vector.ts line 432 at r1 (raw file):

Previously, jolevesq (Johann Levesque) wrote…

CAn you add a comment about why we need this. You can even relate the issue number.

Done.

Copy link
Member

@jolevesq jolevesq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @DamonU2)

Copy link
Member

@jolevesq jolevesq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @DamonU2)

@jolevesq jolevesq merged commit 61b9e6a into Canadian-Geospatial-Platform:develop Jan 16, 2025
6 checks passed
@DamonU2 DamonU2 deleted the 2653-french-character-filter branch January 22, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Not able to filter map, French character
2 participants