-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2422 layer tree selection #2517
base: develop
Are you sure you want to change the base?
2422 layer tree selection #2517
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 8 files at r1, all commit messages.
Reviewable status: 5 of 8 files reviewed, 3 unresolved discussions (waiting on @ychoquet)
packages/geoview-core/src/api/config/types/classes/sub-layer-config/entry-config-base-class.ts
line 294 at r1 (raw file):
/** * Create a clone of this node.
Can you put more information for what this function is about and why it is use. Because itis public it may be use at a lot of places
packages/geoview-core/src/core/components/layers/left-panel/add-new-layer/add-new-layer.tsx
line 170 at r1 (raw file):
}; /// ////////////////////////////////////////////////////////////////////////////////////////////////
What is this?
packages/geoview-core/src/core/components/layers/left-panel/add-new-layer/add-new-layer.tsx
line 172 at r1 (raw file):
/// //////////////////////////////////////////////////////////////////////////////////////////////// /// ////////////////////////////////////////////////////////////////////////////////////////////////
Same here
e3daca5
to
d08c43c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 4 of 8 files reviewed, 3 unresolved discussions (waiting on @jolevesq and @ychoquet)
packages/geoview-core/src/api/config/types/classes/sub-layer-config/entry-config-base-class.ts
line 294 at r1 (raw file):
Previously, jolevesq (Johann Levesque) wrote…
Can you put more information for what this function is about and why it is use. Because itis public it may be use at a lot of places
Done.
packages/geoview-core/src/core/components/layers/left-panel/add-new-layer/add-new-layer.tsx
line 170 at r1 (raw file):
Previously, jolevesq (Johann Levesque) wrote…
What is this?
I can remove, it was there when I started to work on this file.
packages/geoview-core/src/core/components/layers/left-panel/add-new-layer/add-new-layer.tsx
line 172 at r1 (raw file):
Previously, jolevesq (Johann Levesque) wrote…
Same here
I can remove, it was there when I started to work on this file.
e900aac
to
f22d396
Compare
…or add layer tree.
f22d396
to
19ff6d8
Compare
Description
This PR is part of issue 2422-add-new-layer. It contains the code that interpret the selection made by the user in the layer tree. It also has corrections to the config API code for some layers. The implementation is not completely done, a remaining 5% of coding needs to be done to complete the implementation.
Fixes part of issue 2422
Type of change
How Has This Been Tested?
Using the add-layers.html template. URL tested are:
Deploy URL: https://ychoquet.github.io/GeoView/add-layers.html
Checklist:
I have made corresponding changes to the documentationI have added tests that prove my fix is effective or that my feature worksNew and existing unit tests pass locally with my changesThis change is