Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2422 layer tree selection #2517

Open
wants to merge 12 commits into
base: develop
Choose a base branch
from

Conversation

ychoquet
Copy link
Contributor

@ychoquet ychoquet commented Sep 26, 2024

Description

This PR is part of issue 2422-add-new-layer. It contains the code that interpret the selection made by the user in the layer tree. It also has corrections to the config API code for some layers. The implementation is not completely done, a remaining 5% of coding needs to be done to complete the implementation.

Fixes part of issue 2422

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Using the add-layers.html template. URL tested are:

Deploy URL: https://ychoquet.github.io/GeoView/add-layers.html

Checklist:

  • I have build (rush build) and deploy (rush host) my PR
  • I have connected the issues(s) to this PR
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have created new issue(s) related to the outcome of this PR is needed
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

This change is Reviewable

@jolevesq jolevesq self-requested a review September 26, 2024 19:48
@ychoquet ychoquet self-assigned this Sep 26, 2024
Copy link
Member

@jolevesq jolevesq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 8 files at r1, all commit messages.
Reviewable status: 5 of 8 files reviewed, 3 unresolved discussions (waiting on @ychoquet)


packages/geoview-core/src/api/config/types/classes/sub-layer-config/entry-config-base-class.ts line 294 at r1 (raw file):

  /**
   * Create a clone of this node.

Can you put more information for what this function is about and why it is use. Because itis public it may be use at a lot of places


packages/geoview-core/src/core/components/layers/left-panel/add-new-layer/add-new-layer.tsx line 170 at r1 (raw file):

    };

    /// ////////////////////////////////////////////////////////////////////////////////////////////////

What is this?


packages/geoview-core/src/core/components/layers/left-panel/add-new-layer/add-new-layer.tsx line 172 at r1 (raw file):

    /// ////////////////////////////////////////////////////////////////////////////////////////////////

    /// ////////////////////////////////////////////////////////////////////////////////////////////////

Same here

@ychoquet ychoquet force-pushed the 2422-layer-tree-selection branch from e3daca5 to d08c43c Compare September 26, 2024 20:42
Copy link
Contributor Author

@ychoquet ychoquet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 4 of 8 files reviewed, 3 unresolved discussions (waiting on @jolevesq and @ychoquet)


packages/geoview-core/src/api/config/types/classes/sub-layer-config/entry-config-base-class.ts line 294 at r1 (raw file):

Previously, jolevesq (Johann Levesque) wrote…

Can you put more information for what this function is about and why it is use. Because itis public it may be use at a lot of places

Done.


packages/geoview-core/src/core/components/layers/left-panel/add-new-layer/add-new-layer.tsx line 170 at r1 (raw file):

Previously, jolevesq (Johann Levesque) wrote…

What is this?

I can remove, it was there when I started to work on this file.


packages/geoview-core/src/core/components/layers/left-panel/add-new-layer/add-new-layer.tsx line 172 at r1 (raw file):

Previously, jolevesq (Johann Levesque) wrote…

Same here

I can remove, it was there when I started to work on this file.

@ychoquet ychoquet force-pushed the 2422-layer-tree-selection branch 2 times, most recently from e900aac to f22d396 Compare October 1, 2024 00:57
@ychoquet ychoquet force-pushed the 2422-layer-tree-selection branch from f22d396 to 19ff6d8 Compare October 22, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants