Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2364-draft custom legend packages #2432

Draft
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

guichoquette
Copy link
Contributor

@guichoquette guichoquette commented Aug 12, 2024

Description

I tried to create a package working exactly like the AOI panel but named legend instead. The goal was to make sure everything was working properly to then adapt the schema to what the legend package is suppose to do. I still have some issues with the package. It does not appear in app-bar and footer-bar yet as it's suppose to do.

Fixes # (2364)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

I tried to test my package in the loading packages page and the Configuration Navigator page. Strangely the Icon I chose for the package does not appear in both test I did.

The URL for your deploy!

Checklist:

  • I have build (rush build) and deploy (rush host) my PR
  • I have connected the issues(s) to this PR
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have created new issue(s) related to the outcome of this PR is needed
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

This change is Reviewable

@guichoquette guichoquette force-pushed the 2364-Create_Custom_Legend_Package branch from 532a164 to c46c0a0 Compare August 13, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants