-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for new CHERI128 trace format from hardware. #3
Open
jonwoodruff
wants to merge
5
commits into
CTSRD-CHERI:master
Choose a base branch
from
jonwoodruff:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
9c75335
Support for new CHERI128 trace format from hardware.
jonwoodruff 8c31650
A small sample binary trace in the updated CHERI128 format to test a …
jonwoodruff e4826c3
Fix whitespace.
jonwoodruff 90baaf4
A text version of the small trace as interpreted by berictl. Times a…
jonwoodruff 0eca53f
Add detailed comments to CHERI128 assembly routine.
jonwoodruff File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
Time= 19985 : 9800000040000c9c: 48041800 DestReg <- 0x000000000007ffff {0} | ||
Time= 19986 : 9800000040000ca0: 49a51802 DestReg <- 0x0000000000001234 {0} | ||
Time= 19987 : 9800000040000ca4: 48061802 DestReg <- 0x9800000040000000 {0} | ||
Time= 19988 : 9800000040000ca8: 48071803 DestReg <- 0x0000000012347000 {0} | ||
Time= 19989 : 9800000040000cac: 48081805 DestReg <- 0x0000000000000001 {0} | ||
Time= 19990 : 9800000040000cb0: 08000324 j 0x9800000040000c90 branch to 0x9800000040000c90 {0} | ||
Time= 19991 : 9800000040000cb4: 00000000 nop {0} | ||
Time= 19992 : 9800000040001234: f8406000 sdc2 r0,24576(v0) [] Address 0x9800000040000d60 <- tag: 1 u:0 perms:0x3fff type:0x0000000000000000 offset:0x0000000000001234 base:0x9800000040000000 length:0x0000000012347000 {0} | ||
Time= 19993 : 9800000040001234: d8606000 ldc2 r0,24576(v1) [] CapReg <- tag: 1 u:0 perms:0x3fff type:0x0000000000000000 offset:0x0000000000001234 base:0x9800000040000000 length:0x0000000012347000 from Address 0x9800000040000d60 {0} | ||
Time= 19996 : 9800000040000c98: 49a31800 CapReg <- tag: 1 u:0 perms:0x3fff type:0x0000000000000000 offset:0x0000000000001234 base:0x9800000040000000 length:0x0000000012347000 {0} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first half of this comment is confusing, as it's talking about where these values come from long before they get to this function.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. This is brought forward from the older variations of this function. If we want to change the comment, we should change it everywhere.