Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added protein tests and updated readme #69

Merged
merged 4 commits into from
Mar 14, 2024
Merged

added protein tests and updated readme #69

merged 4 commits into from
Mar 14, 2024

Conversation

tulika-jha
Copy link
Contributor

@tulika-jha tulika-jha commented Mar 14, 2024

Added protein tests, update README, clean failing beta test for previous PR

♻️ Current situation & Problem

  • No protein tests, less code coverage
  • Previous PR failing for a UI test

⚙️ Release Notes

  • Added protein tests
  • Updated README with protein tracking documentation

📚 Documentation

Please ensure that you properly document any additions in conformance to Spezi Documentation Guide.
You can use this section to describe your solution, but we encourage contributors to document your reasoning and changes using in-line documentation.

✅ Testing

Please ensure that the PR meets the testing requirements set by CodeCov and that new functionality is appropriately tested.
This section describes important information about the tests and why some elements might not be testable.

📝 Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.82%. Comparing base (92790a7) to head (df0d928).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
+ Coverage   68.78%   68.82%   +0.04%     
==========================================
  Files          43       43              
  Lines        3030     3030              
==========================================
+ Hits         2084     2085       +1     
+ Misses        946      945       -1     

see 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92790a7...df0d928. Read the comment docs.

StrongerUITests/HomeTest.swift Show resolved Hide resolved
@terribilis terribilis merged commit e1e36bf into main Mar 14, 2024
7 checks passed
@terribilis terribilis deleted the protein_tests branch March 14, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants